Authorized keys bug fix #34

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
Contributor

mbrevoort commented Jul 18, 2013

Clients who specified no key could publish services and make changes
rejected.js test was broken
Added missing_key.js test

This fixes bugs in the authorized key verification logic. Clients who specified no key could publish services.
Also, the "rejected" test was broken. It wasn't passing authorized keys properly, passing the set of keys rather than just the public key. It also expected to receive a reject event on message type address which shouldn't happen because "untrusted" should still be able to connect and query, just not register services and change data. So the test logic was changed to look for a reject emitted on the server for the service registration attempt.

Going forward, it seems incomplete that the the untrusted isn't notified that there key is invalid and that there service registration failed because of an invalid key, unless we trigger a delete change event on the registration that should delete their local copy. For another day...

@mbrevoort mbrevoort Authorized keys bug fix
Clients who specified no key could publish services and make changes
rejected.js test was broken
Added missing_key.js test
c6f1575
Owner

substack commented Jul 18, 2013

Merged and published in 1.5.1.

substack closed this Jul 18, 2013

Contributor

mbrevoort commented Jul 18, 2013

Suuuuuper fast! Thanks!

Contributor

nisaacson commented Jul 19, 2013

Awesome thanks for fixing this @mbrevoort and thanks @substack for adding in these changes so quickly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment