patch for skipping 'end', 'close' events #23

Open
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants

stream.destroy() invokes stream.removeAllListeners() within SockJS's closing sequence. To make 'end', 'close' handlers called properly, stream.destroy() should be deferred.

@nakosung nakosung defer 'calling destroy' after 'closing sequence'
stream.destroy() invokes stream.removeAllListeners() within SockJS's closing sequence. To make 'end', 'close' handlers called properly, stream.destroy() should be deferred.
814d088

nakosung closed this Jun 24, 2013

nakosung reopened this Jun 24, 2013

Contributor

dominictarr commented Aug 1, 2013

That is a bug in sockjs

https://github.com/sockjs/sockjs-node/blob/master/src/transport.coffee#L44

I posted an issue about that a while back...
sockjs/sockjs-node#79

Probably best to just not call destroy, since sockjs doesn't bother to implement destroy correctly.

Looks like it has been fixed in sockjs. Can we update the dependency to 0.3.15?

Aw, nope, it's still not fixed. I still don't get a close or end event if I disconnect

Nah, that's because I'm using shoe-bin, will submit a patch there...

marcelklehr referenced this pull request in substack/shoe-bin Aug 7, 2015

Closed

Pass on 'close' event #2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment