Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Report skipped assertions #197
This should address some of #90
I should be able to look at the last bit in the next week or two.
TLDR: needs a bit more work to match the spec. Should allow a string value for skip option, which is the skip reason.
I think I need to change a bit of the code back to fit the spec, and there are a few more things to add. I have copied what look like the relevant parts of the spec here for convenience (quoted sections are all from TAP 13 specification).
There is a possible point of ambiguity with skipped tests: should the test description be shown for skipped tests? None of the examples show both a description and a directive (
If tape currently just doesn't report anything for
If you DO choose to say something about tests that are skipped (which, imo, is a good idea), then yes, the format like
node-tap lets you pass either a string or a boolean as the skip option. For example:
The default reporter shows this as "pending tests" in mocha-speak:
@davidmason are you still interested in completing this?
If so, let's get a fresh rebase on master, please check the "allow edits" box on the right hand column of the PR, and let's get a restatement of what this PR is currently changing and what is still left to do (possibly in a future PR).
My sense is that "making skipped tests count towards the plan" is a useful, albeit breaking, change, and "including the skip count in the output" is also an excellent change. Making