Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add -i flag to specify ignore files #492

Merged
merged 1 commit into from Jan 8, 2020
Merged

Conversation

@r0mflip
Copy link
Contributor

r0mflip commented Jan 7, 2020

Fixes #428

Confirming to #428 (comment)

Closes #451.

@r0mflip r0mflip changed the title feat: Add -i flag to ignore files from gitignore feat: Add -i flag specify ignore files Jan 7, 2020
@r0mflip r0mflip changed the title feat: Add -i flag specify ignore files feat: Add -i flag to specify ignore files Jan 7, 2020
Copy link
Collaborator

ljharb left a comment

(I'll do a cleanup pass on dotignore and publish a new patch if needed before merging this :-D)

Thanks, this is great!

bin/tape Outdated Show resolved Hide resolved
bin/tape Outdated Show resolved Hide resolved
bin/tape Outdated Show resolved Hide resolved
@ljharb ljharb force-pushed the r0mflip:dotignore branch 3 times, most recently from 73a6532 to 3aa123c Jan 8, 2020
@ljharb
ljharb approved these changes Jan 8, 2020
Copy link
Collaborator

ljharb left a comment

Went ahead and made the changes. Thanks!

@ljharb ljharb force-pushed the r0mflip:dotignore branch 2 times, most recently from 7b52a88 to a0f9350 Jan 8, 2020
@ljharb ljharb merged commit a0f9350 into substack:master Jan 8, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
ljharb added a commit that referenced this pull request Jan 8, 2020
ljharb added a commit to ljharb/tape that referenced this pull request Jan 8, 2020
v4.13.0
  - [New] `tape` binary: Add -i flag to ignore files from gitignore (substack#492)
  - [New] add `t.match()` and `t.doesNotMatch()`, new in `node` `v13.6`
  - [Deps] update `resolve`
  - [Tests] handle stack trace variation in node <= 0.8
  - [lint] fix object key spacing
ljharb added a commit that referenced this pull request Jan 8, 2020
v4.13.0

  - [New] `tape` binary: Add -i flag to ignore files from gitignore (#492)
  - [New] add `t.match()` and `t.doesNotMatch()`, new in `node` `v13.6`
  - [Deps] update `resolve`
  - [Tests] handle stack trace variation in node <= 0.8
  - [lint] fix object key spacing
@r0mflip

This comment has been minimized.

Copy link
Contributor Author

r0mflip commented Jan 8, 2020

Sorry I didn't look at any of your comments and review. I am on the other side of the world as you. Timing issues 😝

@r0mflip r0mflip deleted the r0mflip:dotignore branch Jan 8, 2020
ljharb added a commit to ljharb/tape that referenced this pull request Jan 8, 2020
Changes since v5.0.0-next.1:

 - [New] `tape` binary: Add -i flag to ignore files from gitignore (substack#492)
 - [New] add `t.match()` and `t.doesNotMatch()`, new in `node` `v13.6`
 - [readme] remove long-dead testling-ci badge

Changes since v4.13.0:

 - [Breaking] `error` should not emit `expected`/`actual` diags (substack#455)
 - [Breaking] support passing in an async function for the test callback (substack#472)
 - [Breaking] update `deep-equal` to v2
 - [Deps] update `resolve`
 - [meta] change dep semver prefix from ~ to ^
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.