Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Comments should not make exit code incorrect. Fixes #92 #94

Closed
wants to merge 1 commit into from

2 participants

@tmcw

No description provided.

@substack
Owner

Published in 2.13.4. Thanks for the patch!

@substack substack closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jul 19, 2014
  1. @tmcw
This page is out of date. Refresh to see the latest.
Showing with 3 additions and 1 deletion.
  1. +1 −1  index.js
  2. +1 −0  test/exit.js
  3. +1 −0  test/exit/ok.js
View
2  index.js
@@ -118,7 +118,7 @@ function createHarness (conf_) {
inspectCode(st_);
});
st.on('result', function (r) {
- if (!r.ok) test._exitCode = 1
+ if (!r.ok && typeof r !== 'string') test._exitCode = 1
});
})(t);
View
1  test/exit.js
@@ -18,6 +18,7 @@ tap.test('exit ok', function (t) {
t.same(rs, [
'TAP version 13',
'array',
+ 'hi',
{ id: 1, ok: true, name: 'should be equivalent' },
{ id: 2, ok: true, name: 'should be equivalent' },
{ id: 3, ok: true, name: 'should be equivalent' },
View
1  test/exit/ok.js
@@ -2,6 +2,7 @@ var falafel = require('falafel');
var test = require('../../');
test('array', function (t) {
+ t.comment('hi');
t.plan(5);
var src = '(' + function () {
Something went wrong with that request. Please try again.