Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

making two-factor auth work #8

Closed
wants to merge 1 commit into from

2 participants

@toddself

Travisify was unable to auth against github with my a personal access token.

Now it can.

@toddself

In light of heartbleed and revoking tokens/sessions, it would be awesome if travisify supported github's 2fa so I don't have to keep using my fork.

Anything you need to get this merged in?

@tmcw

:+1: happy to help get this merged

@toddself

Actually, easier work around -- about to close this!

If you're using 2fa, you can just generate a new auth token and use that as your username. Then either provide no password or x-oauth-basic

This will work as intended from there on out.\

cc @tmcw

@toddself toddself closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Nov 13, 2013
  1. @toddself

    making 2factor auth work

    toddself authored
This page is out of date. Refresh to see the latest.
Showing with 8 additions and 1 deletion.
  1. +8 −1 bin/cmd.js
View
9 bin/cmd.js
@@ -70,8 +70,15 @@ withConfig(function (config) {
});
function hookUri (config, repo) {
+ var user = config.user;
+ var pass = config.pass;
+ if(config.token){
+ user = config.token;
+ pass = 'x-oauth-basic';
+ }
+
return 'https://'
- + [ config.user, config.pass ].map(encodeURIComponent).join(':')
+ + [ user, pass ].map(encodeURIComponent).join(':')
+ '@api.github.com/repos/' + repo + '/hooks'
;
}
Something went wrong with that request. Please try again.