Model Based Editor Challenge

[obuchtala]

Here we collect issues we want to address after the first iteration on a model based editor implementation is done:

• Remove XML nodes for References from InternalModel
• Fix styling of citation dropdown (aka EditXrefTool)
• Bring back Importer + Exporter (fixing currently broken PersistenceTest)
• Reader preparations: proof of concept
• Tidy-up dead code
• Editor configuration (read-only vs editable)
• Metadata counters aren't updated on delete
• When a new item added in metadata editor we want to scroll to new item and put a selection on a first field
• Xref toggling rerendering glitches (labels updated only on next rendering cycle)
• Deletion of translations does not work
• Display select box for choosing language (e.g. in keywords, subjects)
• Implement RemoveContrib/AddContrib in InPlaceContribEditor.
• editing a ref-contrib in the in place editor does not update the preview
• warnings are not displayed properly (e.g. when i remove all text from surname of an author it should put a warning, or webpage reference example shows a warning for container title, but it does not go away after entering it.
• Figures section is shown in Metadata editor but no figures
• remove cursor style when hovering the ref list in manuscript view
  there’s a pointer cursor currently
• figure and table styles are missing
• remove all that hide/show section stuff (e.g. the tools and commands and also update the components to show or not show up, based on if there is >0 references, authors etc.
• disable overlay when selection changes
• 'Cite' is always disabled in ManuscriptEditor
• Add reference is broken
• Table Editing is broken, e.g. cursor navigation (right, down)
• xrefs do not get rendered with label after insert
• Find and replace not working
• When you add a new footnote it has no text inside and you can’t edit it

[Integral]

RemoveContrib/AddContrib for InPlaceRefContribEditor is in #659

[Integral]

Display select box for choosing language is in #660

[Integral]

@oliver---- what Michael described with warnings is related to NodeModelEditor rerendering. We need there an observer which will rerender the editor on model change. Could you help with that?

[obuchtala]

@Integral I guess the Validator is not working properly yet. Will take care of this.

[obuchtala]

should we do custom transaction and insert empty paragraph there? also think _selectFirstRequiredProperty will not work for footnotes if we will not make a content required

@michael @Integral dunno who of you wrote the footnote item. I'd suggest to have discussions in the comments, and all issues in the main description (necessary to have proper counters)

Re the question: I'd say that we should create an initial empty paragraph in this case. That should be the case for all container types, which is also something we should make sure during import.

[Integral]

@oliver---- that was me after slack discussion

[obuchtala]

@Integral We are getting closer. The only major thing I see right now, is the footnote issue.
I will fix 'Find and Replace'.

[obuchtala]

Done.