New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manuscript workflows #647

Merged
merged 11 commits into from Aug 6, 2018

Conversation

Projects
None yet
3 participants
@Integral
Member

Integral commented Aug 6, 2018

We want to use workflows inside a manuscript editor. This comes with a few examples: add new reference and editing refs using workflows.

Note: This is just the first iteration. We want to merge it and improve UX later.

@Integral Integral changed the base branch from master to metadata-editor Aug 6, 2018

@codecov-io

This comment has been minimized.

codecov-io commented Aug 6, 2018

Codecov Report

Merging #647 into metadata-editor will increase coverage by 0.1%.
The diff coverage is 30.64%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           metadata-editor     #647     +/-   ##
==================================================
+ Coverage            53.22%   53.33%   +0.1%     
==================================================
  Files                  256      257      +1     
  Lines                 7013     7012      -1     
==================================================
+ Hits                  3733     3740      +7     
+ Misses                3280     3272      -8
Impacted Files Coverage Δ
src/article/shared/FormRowComponent.js 100% <ø> (ø)
src/article/shared/AddReferenceWorkflow.js 5% <ø> (ø)
src/article/shared/ReferencePropertyEditor.js 100% <ø> (ø)
src/article/shared/DOIInputComponent.js 2% <ø> (ø)
src/article/shared/SelectInput.js 41.93% <ø> (ø)
src/article/shared/CardComponent.js 100% <ø> (ø)
src/article/metadata/TranslateableEditor.js 69.23% <ø> (ø) ⬆️
src/article/shared/TextInput.js 60% <ø> (ø)
src/article/shared/TranslationPropertyEditor.js 100% <ø> (ø)
src/article/metadata/CollectionEditor.js 84.61% <ø> (-1.1%) ⬇️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d6bd9a...13bd159. Read the comment docs.

@oliver----

Looking good so far.

@@ -80,6 +80,8 @@ import {
import InsertTableTool from './InsertTableTool'
import SchemaAwareToggleListCommand from './SchemaAwareToggleListCommand'
import ArticleNavPackage from '../ArticleNavPackage'
// Workflows
import AddReferenceWorkflow from '../metadata/AddReferenceWorkflow'

This comment has been minimized.

@oliver----

oliver---- Aug 6, 2018

Member

You can move this into '../shared'

This comment has been minimized.

@Integral

Integral Aug 6, 2018

Member

yes, i also thought about this...
do we want to introduce shared styles as well?

This comment has been minimized.

@oliver----

oliver---- Aug 6, 2018

Member

Yes, I guess

This comment has been minimized.

@oliver----

oliver---- Aug 6, 2018

Member

After my (hoperfully soon) merge, we should do a tidy-up. Eliminate dead code and reduce code/CSS redundancy

This comment has been minimized.

@Integral

Integral Aug 6, 2018

Member

Nice, meanwhile I will remove dead code from RefListComponent.

This comment has been minimized.

@oliver----

@Integral Integral changed the title from WIP: Manuscript workflows to Manuscript workflows Aug 6, 2018

@Integral Integral merged commit 720ff83 into metadata-editor Aug 6, 2018

3 of 4 checks passed

codecov/patch 30.64% of diff hit (target 53.22%)
Details
codecov/project 53.33% (+0.1%) compared to 9d6bd9a
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@Integral Integral deleted the manuscript-workflows branch Aug 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment