Update cron.php #168

Open
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants

Remove check for php_sapi_name() == 'cli'. The cron.php code was failing to run on large shared linux servers.
Reason: Many well tuned large Linux servers, run cron jobs in cgi mode, not cli, for greater CPU efficiency, lower memory use, and better PHP opcode caching. But some servers run cron jobs in php cli mode. So you can never rule out either mode.

@chris001 chris001 Update cron.php
Remove check for php_sapi_name() == 'cli'. The cron.php code was failing to run on large shared linux servers.
Reason: Many well tuned large Linux servers, run cron jobs in cgi mode, not cli, for greater CPU efficiency, lower memory use, and better PHP opcode caching.  But some servers run cron jobs in php cli mode.  So you can never rule out either mode.
e4d186c

Sugared commented Oct 4, 2013

Hi Chris001,

thanks for submitting this pull request. One problem with this request is that this would then open up cron.php to being run from the browser, which we don't to do. Perhaps there is another super global variable we can check against to make sure we are not coming from a browser request but that would still allow a cgi script?

Sugared commented Oct 4, 2013

Chris001,

is it possible for you to fill out a bug for this issue through our bug portal ( http://bugs.sugarcrm.com/ )? Please make sure to include steps on how to reproduce the bug being solved for our QA team to track the issue. It also helps us to reference your pull request in the bug description.

thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment