Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Fix line 342 to write correct meta http-equiv="Content-Type" content #192

Open
wants to merge 1 commit into from

2 participants

@ibetanzos

Now the charset var is not correctly set (cause the var is not being expanded) in meta http-equiv="Content-Type" content=
Now:
Fixed so it now takes the var valor

@ibetanzos ibetanzos Fix line 342 to write correct meta http-equiv="Content-Type" content
Now the charset var is not correctly set (cause the var is not being expanded) in meta http-equiv="Content-Type" content=
Now: <meta http-equiv="Content-Type" content="text/html; charset=" {$charset}">
Fixed so it now takes the var valor 
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
86c8036
@chris001

Looks good for html4.
In html5 this would be simply:
echo '<meta charset='."{$charset}".'">';
For example:
<meta charset=utf-8>

I've found it cause when I was editing an email template the characters like accents and ñ went wrong, then I've realized that the meta content-type was wrong cause the $charset var is not expanded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jan 14, 2014
  1. @ibetanzos

    Fix line 342 to write correct meta http-equiv="Content-Type" content

    ibetanzos authored
    Now the charset var is not correctly set (cause the var is not being expanded) in meta http-equiv="Content-Type" content=
    Now: <meta http-equiv="Content-Type" content="text/html; charset=" {$charset}">
    Fixed so it now takes the var valor 
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1  include/utils/layout_utils.php
View
2  include/utils/layout_utils.php
@@ -339,7 +339,7 @@ function insert_popup_header(
if ($includeJS)
{
$charset = isset($app_strings['LBL_CHARSET']) ? $app_strings['LBL_CHARSET'] : $sugar_config['default_charset'];
- echo '<meta http-equiv="Content-Type" content="text/html; charset="{$charset}">';
+ echo '<meta http-equiv="Content-Type" content="text/html; charset='."{$charset}".'">';
echo '<script type="text/javascript" src="' . getJSPath('cache/include/javascript/sugar_grp1_yui.js') . '"></script>';
echo '<script type="text/javascript" src="' . getJSPath('cache/include/javascript/sugar_grp1.js') . '"></script>';
echo '</head>';
Something went wrong with that request. Please try again.