Many AJAX requests fail because $module_dir is passed as an MBModule object #33

Open
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants

msnider commented Jul 22, 2011

Many AJAX requests fail because $module_dir is passed as an MBModule object which cannot be converted to a string. The solution is to get the module name when applicable. Without this patch, many AJAX requests in the Module Builder break.

For more details see: http://www.sugarcrm.com/forums/showthread.php?t=73603

@msnider msnider Many AJAX requests fail because $module_dir is passed as an MBModule …
…object which cannot be converted to a string. The solution is to get the module name when applicable. Without this patch, many AJAX requests in the Module Builder break.
5e22b7a
Contributor

jmertic commented Jul 22, 2011

Hi Matt!

Thanks for this fix. Is there an existing bug in the SugarCRM bug tracker for this so we can track this for QA purposes ( http://bugs.sugarcrm.com )?

Also, we need to have a unit test to cover this fix. We have documentation on our wiki for this; please feel free to ask if you need any help in putting this together.

Thanks!

John Mertic

Contributor

jmertic commented Mar 19, 2012

Hey Matt,

Would love to pull this fix in, just need two things from you:

Thanks, and look forward to hearing back from you.

I second what John says. Good fix, Matt!

Contributor

jmertic commented Feb 28, 2013

Hi JanSiero!

Wanted to check back if you could get a bug and contribution agreement done for this pull request. We cannot pull in the fix without one.

Thanks!

John Mertic
Sugar Community Manager

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment