feature 'Text Notify in controller' fixes bug #45527 #34

Open
wants to merge 2 commits into
from

2 participants

@lukio

http://www.sugarcrm.com/crm/support/bugs.html#issue_45527

The idea of this feature request, is to let SugarCRM developers
to set text notify between requests.

sugar_set_notify("Warning, this is an error.", "error");
sugar_set_notify("Alert", "alert");
sugar_set_notify("Its fine", "success");
sugar_set_notify("info notify", "info");
sugar_set_notify("working...", "working");

@lukio lukio feature 'Text Notify in controller' fixes bug #45527
http://www.sugarcrm.com/crm/support/bugs.html#issue_45527

The idea of this feature request, is to let SugarCRM developers
to set text notify between requests.

sugar_set_notify("Warning, this is an error.", "error");
sugar_set_notify("Alert", "alert");
sugar_set_notify("Its fine", "success");
sugar_set_notify("info notify", "info");
sugar_set_notify("working...", "working");
64ff68c
@jmertic

This looks very interesting. I'm going to do a review of the feature ( as well as have our PM team do a review as well ). In the meantime, can you add unit test coverage for the added functions?

Thanks!

@lukio

Hello jmertic

I made a unit test for these feature.

Thanks!

@jmertic

Hi luklo,

Have you looked at the existing way add error messages in SugarApplication::appendErrorMessage()? I'm thinking this takes care of the core part of the feature you are adding ( the ability to raise notifications from code to the user ). I think you'd be farther ahead to instead enhance this to make it a bit more robust like you have done rather than add an entirely different framework.

Let me know your thoughts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment