V5

[JuiP]

@quozl @chimosky :)

[quozl]

Thanks. Reviewed.

Probably blocked by #14.

[chimosky]

Yes I agree, it's blocked by #14.

[JuiP]

I don't agree with the change in #14 so I made the change in this branch and rebased.
TypeError was reported by @Saumya-Mishra9129 Thanks 😄

I checked GObject.py in the path /usr/lib/python3/dist-packages/gi/overrides for Ubuntu 18.04 LTS, 20.04 LTS and Debian Buster,

For Debian buster and Ubuntu 18.04 python3-gi package, it raises Value Error when set_value is called

For Ubuntu 20.04 python3-gi package, it raises Type Error when set_value is called

Since Value Error was previously handled, there were no tracebacks when I tested on Debian Buster. However, tracebacks:

  File "/usr/share/sugar/activities/analyzeJournal/activity.py", line 443, in __import_freespace_cb
    self._graph_from_reader(reader)
  File "/usr/share/sugar/activities/analyzeJournal/activity.py", line 425, in _graph_from_reader
    self._add_value(None, label=row[0], value=float(row[1]))
  File "/usr/share/sugar/activities/analyzeJournal/activity.py", line 432, in _add_value
    pos = self.labels_and_values.add_value(label, value)
  File "/usr/share/sugar/activities/analyzeJournal/activity.py", line 582, in add_value
    _iter = self.model.insert(path, [label, value])
  File "/usr/lib/python3/dist-packages/gi/overrides/Gtk.py", line 1007, in insert
    return self._do_insert(position, row)
  File "/usr/lib/python3/dist-packages/gi/overrides/Gtk.py", line 988, in _do_insert
    row, columns = self._convert_row(row)
  File "/usr/lib/python3/dist-packages/gi/overrides/Gtk.py", line 900, in _convert_row
    result.append(self._convert_value(cur_col, value))
  File "/usr/lib/python3/dist-packages/gi/overrides/Gtk.py", line 914, in _convert_value
    return GObject.Value(self.get_column_type(column), value)
  File "/usr/lib/python3/dist-packages/gi/overrides/GObject.py", line 210, in __init__
    self.set_value(py_value)
  File "/usr/lib/python3/dist-packages/gi/overrides/GObject.py", line 249, in set_value
    raise TypeError("Expected string but got %s%s" %
TypeError: Expected string but got 10590.3046875<class 'float'>
Traceback (most recent call last):
  File "/usr/share/sugar/activities/analyzeJournal/activity.py", line 447, in __import_journal_cb
    self._graph_from_reader(reader)
  File "/usr/share/sugar/activities/analyzeJournal/activity.py", line 425, in _graph_from_reader
    self._add_value(None, label=row[0], value=float(row[1]))
  File "/usr/share/sugar/activities/analyzeJournal/activity.py", line 432, in _add_value
    pos = self.labels_and_values.add_value(label, value)
  File "/usr/share/sugar/activities/analyzeJournal/activity.py", line 582, in add_value
    _iter = self.model.insert(path, [label, value])
  File "/usr/lib/python3/dist-packages/gi/overrides/Gtk.py", line 1007, in insert
    return self._do_insert(position, row)
  File "/usr/lib/python3/dist-packages/gi/overrides/Gtk.py", line 988, in _do_insert
    row, columns = self._convert_row(row)
  File "/usr/lib/python3/dist-packages/gi/overrides/Gtk.py", line 900, in _convert_row
    result.append(self._convert_value(cur_col, value))
  File "/usr/lib/python3/dist-packages/gi/overrides/Gtk.py", line 914, in _convert_value
    return GObject.Value(self.get_column_type(column), value)
  File "/usr/lib/python3/dist-packages/gi/overrides/GObject.py", line 210, in __init__
    self.set_value(py_value)
  File "/usr/lib/python3/dist-packages/gi/overrides/GObject.py", line 249, in set_value
    raise TypeError("Expected string but got %s%s" %
TypeError: Expected string but got 25.0<class 'float'> 

Were seen for Ubuntu 20.04
Since, just the exception it raises when set_value is called is different,(difference in packages of different distros) I think this is the best way to fix it. (As done in 3ce8ce9)
@quozl @chimosky @Saumya-Mishra9129 kindly review

[quozl]

Agreed, well found.

[Saumya-Mishra9129]

Were seen for Ubuntu 20.04
Since, just the exception it raises when set_value is called is different,(difference in packages of different distros) I think this is the best way to fix it. (As done in 3ce8ce9)

Thanks @JuiP , I agree , Reviewed and Tested. Works fine 👍

[chimosky]

Good find @JuiP, reviewed. Thanks.