Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #17

Merged
merged 16 commits into from Jul 6, 2020
Merged

Fixes #17

merged 16 commits into from Jul 6, 2020

Conversation

JuiP
Copy link
Member

@JuiP JuiP commented Jun 10, 2020

WIP

  • Port to python3

  • Clicking on the level drop down, no other levels are shown when hard level is selected

  • Clicking on the area beside 3,6,9 number buttons : mouse clicks enters number 4 and 7 in the dash

  • Clicking on the toolbar and then the add to desciption button causes black screen

  • Hard level dashes do not fit the screen

  • The smile is not centered

Fixes #16.

@JuiP JuiP mentioned this pull request Jun 10, 2020
JuiP added 3 commits June 10, 2020 09:52
- Fixes bug: Click on the toolbar and then click add description. This causes black screen. Keep the mouse on the toolbar, once the mouse is moved over the canvas, black screen disappears
Copy link
Member

@srevinsaju srevinsaju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Did a code review; will test this soon 😄
very descriptive commit messages 👍

CowBulls.py Outdated Show resolved Hide resolved
activity.py Outdated Show resolved Hide resolved
g.py Show resolved Hide resolved
icons/new-game.svg Outdated Show resolved Hide resolved
utils.py Outdated Show resolved Hide resolved
utils.py Outdated Show resolved Hide resolved
JuiP added 4 commits June 10, 2020 23:13
- Remove unnecessary changes made by 2to3 tool and change choice to randint for better code
- Fix EOL for new-game.svg
- Fix: flake8 last changes
TypeError: randint() missing 1 required positional argument: 'b'
The Type Error also causes IndexError: list index out of range on line utils.blit_offset('status/' + self.compare_list[num][x],

To Reproduce the error: Input one numberwhen on Level `Easy` Then shift the level to `Hard`. The Error occurs
@JuiP JuiP mentioned this pull request Jun 30, 2020
- To reproduce: Clicking on area beside 3,6,9 dialpad keys, mouse click enters number 4 and 7 in the input number dash
@JuiP
Copy link
Member Author

JuiP commented Jul 3, 2020

Tested; worked like expected.
@srevinsaju @chimosky @quozl Please test, review and merge :)

Merging this PR also closes #16

@chimosky
Copy link
Member

chimosky commented Jul 6, 2020

Reviewed, tested. Thanks.

edited opening comment.

The mouse issue you noticed still persists, have you found the cause or any speculations?
I'm yet to take a look.

@JuiP
Copy link
Member Author

JuiP commented Jul 6, 2020

Thanks! :)

Regarding the mouse issue, seems like it happens in every game that uses pygame, @quozl confirmed in comment

@chimosky
Copy link
Member

chimosky commented Jul 6, 2020

Thanks for that.

@chimosky chimosky merged commit 49bf2d4 into sugarlabs:master Jul 6, 2020
@JuiP JuiP mentioned this pull request Aug 8, 2020
@JuiP JuiP deleted the Fixes branch August 8, 2020 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Black Screen when play button is pressed
4 participants