Rebase and merge with TurtleArt and other changes related to Port #8
Conversation
|
Getting this error while testing
@srevinsaju @chimosky can you review please. |
|
@Saumya-Mishra9129 as the error suggests, there is no *.gschema .xml file as there is on turtleart-activity. |
|
Yeah Thanks, I probably forgot to add that file. I will fix this in morning
…On Wed 10 Jun, 2020, 2:27 AM Srevin Saju, ***@***.***> wrote:
@Saumya-Mishra9129 <https://github.com/Saumya-Mishra9129> as the error
suggests, there is no *.gschema .xml file as there is on turtleart-activity.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#8 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKZH63PNOOFZYB6DTLJ3N4DRV2O2JANCNFSM4NNMCMKQ>
.
|
|
Ok; I will review the diff tomorrow morning too. (got held up with some work) |
|
Reviewed, thanks. As this is an update of upstream changes, all your commit messages should reflect that. |
|
@quozl @chimosky @JuiP @srevinsaju , Please review and test. |
|
Ok as I can't do a huge diff review, I will do an activity testing :D |
|
@Saumya-Mishra9129 what is the test procedure for this activity? I was not able to click on any of the flags, does it use any key combination to activate them? |
Saumya-Mishra9129
force-pushed
the
major
branch
2 times, most recently
from
d340489
to
8cbc1d0
Compare
ImportError: cannot import name RB, introspection typelib not found
Saumya-Mishra9129
force-pushed
the
major
branch
from
54370d9
to
1f7f57d
Compare
No, Actually there were some minor bugs in the code. Fixed them. @chimosky @quozl @srevinsaju Please test and merge. |
|
@chimosky I have tested activity works fine. Please merge. |
|
Reviewed, thanks. Collaboration seems to be broken for the activity, although this PR has nothing to do with it but if you have the time you can fix it in a new PR. Thanks. |
Rebase and merge with TurtleArt
Port from GStreamer Gst.Message.structure to get_structure()
Port to Python3
Port to GTK3
Port from GConf to GioSettings
Fixes #4, Fixes #1.
@quozl @pro-panda Please review.