Fixes #111
Merged
Fixes #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In other words, cc9f835 is sugarlabs/collabwrapper@b740323. If it were me, I'd cherry-pick from collabwrapper and then rewrite the commit message for any additional context. |
Thanks , Yeah that is a better way. I have changed in 1102aa3 |
blob had been using str in python2.
str in python2 has been changed to bytes in python3.
Use encode to convert the python2 str to python3 bytes.
fixes error raised while testing collaboration:
Traceback (most recent call last):
File "/usr/share/sugar/activities/Browse.activity/collabwrapper.py", line 688, in __notify_state_cb
input_stream = self._get_input_stream()
File "/usr/share/sugar/activities/Browse.activity/collabwrapper.py", line 736, in _get_input_stream
return Gio.MemoryInputStream.new_from_data(self._blob, None)
TypeError: Item 0: Must be number, not str
Regression introduced in sugarlabs/collabwrapper@1395117
Also Reported by : Shaan Subbaiah <shaansubbaiah.cs18@bmsce.ac.in> in http://lists.sugarlabs.org/archive/sugar-devel/2020-June/058458.html
style.zoom method takes uints as an argument. Regression introduced in sugarlabs@8b0e072
typing in the address bar causes several of warnings: (sugar-activity3:7184): Gtk-WARNING **: 16:25:08.511: Failed to set text from markup due to error parsing mar kup: Error on line 2: Entity did not end with a semicolon; most likely you used an ampersand character withou t intending to start an entity — escape ampersand as & Sometimes there can be characters in uri and title such that markup parser can fail to parse the markup. markup_escape_text escapes text so that the markup parser will parse it. Less than, greater than, ampersand, etc. will be replaced with the corresponding entities. Reported by- Shaan Subbaiah <shaansubbaiah.cs18@bmsce.ac.in> in http://lists.sugarlabs.org/archive/sugar-devel/2020-June/058458.html
Hard coded integer constants were used instead of enums imported from TelepathyGLib. Reported-by: Saumya Mishra <2017230@iiitdmj.ac.in>
hash function accepts bytes object. Regression caused in sugarlabs@8b0e072 ("Port to Python 3")
Saumya-Mishra9129
force-pushed
the
fixes
branch
2 times, most recently
from
4d349ea
to
e84bf8f
Compare
|
I am done with changes here. @quozl @chimosky @JuiP @srevinsaju Please Review and suggest. |
|
1f85350 is not the right way to solve the problem of missing methods. Instead the methods and signals should be implemented, even if they are |
|
I agree with @quozl. |
Several errors noticed in DummyBrowser because of non-implemented methods - sugarlabs#75 - sugarlabs#105 - sugarlabs#103 Implement get_allocation and translate_coordinates methods in DummyBrowser Selecting favorite works as intented for PDF. Fixes-sugarlabs#75 Tested with Ubuntu 20.04 by - Saumya Mishra <2017230@iiitdmj.ac.in>
|
Looks fine, thanks. |
JuiP
approved these changes
Jul 9, 2020
|
Reviewed, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
@quozl @srevinsaju @JuiP Please review.
This pull requests addresses errors reported by @shaansubbaiah in mailing list.