Fix ctrl+c and ctrl+v #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: ctrl+c and ctrl+v do not work in the URL entry, but emit an alert sound. Analysis: the key-press-event handlers for the activity, the toolbar, and the entry widget are coded to pass unhandled events to the Gtk.Entry widget, and this happens properly when sugar3.IconEntry is used with the example, but not when used with the activity. Cause unknown. Solution: explicitly handle the ctrl+c and ctrl+v events. References: https://bugs.sugarlabs.org/ticket/4979 https://bugs.sugarlabs.org/ticket/4642 [explicit handling of events] Written-by: GAURAV MISHRA <gauravm043@gmail.com> [test, review, and switch to Gdk.KEY_* constants] Signed-off-by: James Cameron <quozl@laptop.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Problem:
ctrl+candctrl+vdo not work in the URL entry, but emit an alert sound.Analysis: the
key-press-eventhandlers for the activity, the toolbar, and the entry widget are coded to pass unhandled events to theGtk.Entrywidget, and this happens properly when sugar3.IconEntry is used with the example, but not when used with the activity. Cause unknown.Solution: explicitly handle the
ctrl+candctrl+vevents.References:
https://bugs.sugarlabs.org/ticket/4979
https://bugs.sugarlabs.org/ticket/4642
[explicit handling of events]
Written-by: GAURAV MISHRA gauravm043@gmail.com
[test, review, and switch to Gdk.KEY_* constants]
Signed-off-by: James Cameron quozl@laptop.org