Fix for bug number 4936

[nguyenla]

Fixed bug number 4936 by fixing the method format_decimal() in mathlib.py.

[quozl]

Thanks for your patch. I've applied your patch and calculated sin(179) and sin(181) and the problem mentioned by the bug is fixed.

Some other comments on your commit;

Commit description

• add the problem; at the moment one has to go and read the bug report to find the problem,
• keep first line shorter than 50 characters, as a summary, put details after two line breaks,
• end with a link to https://bugs.sugarlabs.org/ticket/4936

Update bugs.sugarlabs.org

• add reference to your pull request, or if you cannot then say so and we will,
• resolve any doubt as to whether the other two pull requests mentioned were merged,

Hope that helps!

To change the commit message, you might git commit --amend then git push --force to update the pull request.

[quozl]

Thanks, I've packaged a61b8de for use by OLPC.

[quozl]

Should @nguyenla or shiwakoa not resubmit this pull request, then I'll presume they have abandoned work and I'll resubmit it myself.

[nguyenla]

Should I submit a new and separate pull request with the same changes to the code, but with a different commit description then? Please advise me.

[quozl]

Up to you really. Whatever works best for you.

You may either

• git commit --amend to improve the commit message, then git push --force, which will update this pull request, or
• you could clone again, and make new branch, edit, commit, push, and make pull request.

If it were me, the first option would be easier.

Our sending a pull-request guide does not mention the git commit --amend method yet. It is difficult to cover every possible combination of git task.

[quozl]

Replaced by #40, please close #37.