Fix missing sign of result #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- was breaking emacs save, - pep0263 examples use lowercase form, but regular expression is case blind, - pep0263 does also say int he context of Unicode BOM marks, where both are used; "... the only allowed encoding for the comment is 'utf-8'"
- sine of 181 and cosine of 91 should be negative (-0.0174524064), but were displayed without a sign, as if positive (0.0174524064), - sine of 181 multiplied by 10 was correctly displayed negative (-0.174524064), - a constant of -0.01 was displayed as 0.0100000000, - in format_decimal the display was composed with a sign if the value is negative, but when the value was less than 0.1 the sign was discarded, - fix is to keep the sign in the display, - bug has been present since November 2007, see e0c9a2b, - no comprehensive math tests are in the activity; so there may be more such problems. Fixes #4936. https://bugs.sugarlabs.org/ticket/4936 Signed-off-by: James Cameron <quozl@laptop.org>
Closed
|
Hey @nguyenla, could you please review this pull request? You seemed interested in fixing the problem, you originated the patch, so you're a good candidate to make a review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Fixes #4936, thanks to work by @nguyenla.