{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":28012920,"defaultBranch":"master","name":"dotsAndBoxes","ownerLogin":"sugarlabs","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2014-12-15T00:05:56.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/3996398?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1677389421.0","currentOid":""},"activityList":{"items":[{"before":"b64644732d1493a2e8c1c81748c4e8e8de64f2e6","after":"796413a2fc5a815f89dde14dbb8b248a32af4544","ref":"refs/heads/master","pushedAt":"2024-04-23T13:28:41.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"chimosky","name":"Ibiam Chihurumnaya","path":"/chimosky","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/16203834?s=80&v=4"},"commit":{"message":"Update Readme.md","shortMessageHtmlLink":"Update Readme.md"}},{"before":"a41b23ba555c136cfd7e76040fd2629c8330c8b3","after":"b64644732d1493a2e8c1c81748c4e8e8de64f2e6","ref":"refs/heads/master","pushedAt":"2024-03-28T19:29:30.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"quozl","name":"James Cameron","path":"/quozl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2936481?s=80&v=4"},"commit":{"message":"Reset game after win\n\nAfter a player wins the game, the game_reset function isn't called. As a result, while an empty grid is displayed, the game stops working.\r\n\r\nThe reset function isn't called when a player wins the game.\r\n\r\nUntested.","shortMessageHtmlLink":"Reset game after win"}},{"before":"63c7fd116b8f9ecabfe762c4412ece1b203fbe36","after":"a41b23ba555c136cfd7e76040fd2629c8330c8b3","ref":"refs/heads/master","pushedAt":"2024-03-28T19:27:00.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"quozl","name":"James Cameron","path":"/quozl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2936481?s=80&v=4"},"commit":{"message":"Show current player name\n\nUntested.","shortMessageHtmlLink":"Show current player name"}},{"before":"fa389f7c7644a3ebc79b363c0c7f61a716f16910","after":"63c7fd116b8f9ecabfe762c4412ece1b203fbe36","ref":"refs/heads/master","pushedAt":"2023-03-10T09:07:00.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"quozl","name":"James Cameron","path":"/quozl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2936481?s=80&v=4"},"commit":{"message":"Bug Fix : Updating colors makes the game state disappear (#19)\n\n* Bug Fix : Updating colors makes the game state disappear\r\n\r\n## The Issue\r\nThe colors changing option for lines, points and background caused the entire game state to disappear after the changing the color\r\n\r\n## How to replicate the bug\r\n1. Launch the activity\r\n2. Marks a few lines and own a few square\r\n3. Change any one of the colors\r\n4. Notice that the entire board has disappeared \r\n\r\n## Demonstration\r\n\"image\r\n\r\nThe colors changing option for lines, points and background caused the entire game state to disappear after the changing the color\r\nThis was due to the board being cleared and the newer lines having the new colors but the older lines not being redrawn\r\n\r\nI have added a function called `draw_board` on the `Game` class which re-renders all the lines and also the owners of each boxes (if they are owned)\r\n\r\ncalling the function every time any color is changed ensures that the state is visible even after changing the colors\r\n\r\n* floor division instead of plain regular in draw_board\r\n\r\n* Fix missing preview request\r\n\r\n* bug fix: new game did not reset board only made iboard disappear\r\n\r\n* refactored set_board_size and reset_game to make them more modular by implementing clear_game function","shortMessageHtmlLink":"Bug Fix : Updating colors makes the game state disappear (#19)"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEOBvUHwA","startCursor":null,"endCursor":null}},"title":"Activity ยท sugarlabs/dotsAndBoxes"}