push from pootle #2
Conversation
|
Ping. Can we land this please? |
|
Thanks, that reminds me. Isn't this a older version of https://github.com/sugarlabs/get-books-activity ? A quick look at the history of both repositories suggests this one might be orphaned after the changes are merged. get-books-activity and getiabooks share a common ancestor commit at 7bb6f39 in 2009, when OPDS support was added to get-books-activity. getiabooks last functional change was in 2013 with 5bad15f. get-books-activity has continued to receive functional changes right up to the end of 2016. Both are listed on translate.sugarlabs.org. I've not compared the activities functionally. |
|
James,
Please refer to E-Book Enlightenment for the difference between these two
Activities:
http://write.flossmanuals.net/e-book-enlightenment/sugar-activities-for-finding-e-books/
Get IA Books works with Internet Archive specifically. Because of that it
can do a few things that the later program Get Books can't. Get Books uses
OPDS support, which means it can't do things specific to Internet Archive
like download formats besides PDF. I think it deserves to not be orphaned
for that reason.
James Simmons
…On Mon, Feb 20, 2017 at 1:43 AM, James Cameron ***@***.***> wrote:
Thanks, that reminds me. Isn't this a older version of
https://github.com/sugarlabs/get-books-activity ? A quick look at the
history of both repositories suggests this one might be orphaned after the
changes are merged.
get-books-activity and getiabooks share a common ancestor commit at
7bb6f39
<7bb6f39>
in 2009, when OPDS support was added to get-books-activity.
getiabooks last functional change was in 2013 with 5bad15f
<5bad15f>
.
get-books-activity has continued to receive functional changes right up to
the end of 2016.
Both are listed on translate.sugarlabs.org.
I've not compared the activities functionally.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#2 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AJuZYZbTskeYeSHQ3wuCnVX9wDJd7Czvks5reUQSgaJpZM4IkBny>
.
|
|
Thanks. Looks like E-Book Enlightenment has not kept up with developments. I can't find a published date; when was it? Get Books uses the Advanced Search form query for Internet Archive, supports the other download formats including Deja Vu and EPUB, and shows other metadata such as language and publisher. The code that does the search is in opds.py but it does not use OPDS; the code should move to a different file. Get Books uses OPDS for other book repositories. Here is Get Books 16 with the same query as in the E-Book Enlightenment screenshot:
|
|
I guess the manual is out of date. Ironically, writing my two manuals led
me to do a lot of other writing and the manuals have gone out of date. The
Git chapter in *Make Your Own Sugar Activities* describes the old
repository, I understand that there have been significant changes to how
shared Activities work, and now this.
It sounds like Get IA Books could be retired after all.
James Simmons
…On Mon, Feb 20, 2017 at 3:59 PM, James Cameron ***@***.***> wrote:
Thanks. Looks like E-Book Enlightenment has not kept up with developments.
I can't find a published date; when was it? Get Books uses the Advanced
Search form query for Internet Archive, supports the other download formats
including Deja Vu and EPUB, and shows other metadata such as language and
publisher. The code that does the search is in opds.py
<https://github.com/sugarlabs/get-books-activity/blob/master/opds.py#L434>
but it does not use OPDS; the code should move to a different file. Get
Books uses OPDS for other book repositories.
Here is Get Books 16 with the same query as in the E-Book Enlightenment
screenshot
[image: get-books]
<https://cloud.githubusercontent.com/assets/2936481/23142993/f8583018-f812-11e6-8e87-50c701b0763c.png>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#2 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AJuZYX5UkFoSC65QbIpI7ECEeM1mYNCJks5regzYgaJpZM4IkBny>
.
|
|
Thanks. I'll review the two activities to figure out if there is any feature missing, and push the feature into the one with the most features. I don't know which one will end up kept, so this translation pull request can be merged. Sorry for distracting! |
No description provided.