Release v23 #20
Merged
Release v23 #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix the variable names, consistent with other activities
|
@srevinsaju @Saumya-Mishra9129 @chimosky @quozl Please test and review changes so I can go ahead with the release :) |
srevinsaju
reviewed
Jun 19, 2020
AttributeError : 'IQ' object has no attribute 'SQUARE' Seen after commit 595df8f -Reported by Srevin Saju
srevinsaju
reviewed
Jun 21, 2020
There was a problem hiding this comment.
Good work; works fine; Actually some regressions which were made during my port which I found now... smh
-
Mouse cursor is not drawn when cursor moved out of the Sugargame canvas
-
Occasional error:
Traceback (most recent call last):
File "/run/media/srevinsaju/ARCH_DATA/git/iq-activity/IQ.py", line 245, in run
self.do_key(event.key)
File "/run/media/srevinsaju/ARCH_DATA/git/iq-activity/IQ.py", line 92, in do_key
if key in self.SQUARE:
AttributeError: 'IQ' object has no attribute 'SQUARE'
It happens rarely; One way to reproduce might be to wait for sugar desktop to sleep (the screen goes black) and move the mouse to wake it again. the error is possibly to occur. I will update the comment if I find a method to reproduce it.
srevinsaju
approved these changes
Jun 21, 2020
|
Thanks a lot for reviewing and testing! @srevinsaju @Saumya-Mishra9129 |
|
Thanks. Reviewed. Approved. |
|
Tested, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Fix read_file method for resume from journal
Add screenshots of solutions all levels, could be used for adding a help button functionality later.
Other changes to release the activity