Port to Python3 - fix regressions #22
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
http.client.HTTP used to be present in Python 2.0 as httplib.HTTP but It is deprecated completely in python3 and later versions Workaround - Use http.client.HTTPConnection and its methods Regression caused in sugarlabs@5941034
|
You would have to set up a compatible server. It should accept a POST using the content type of multipart/form-data. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
@quozl @pro-panda Can you help with how to test this change? I tried with command
python3 logcollect.py <server address>given herelog-activity/logcollect.py
Line 545 in 0c45118