Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign "welcome message dialog" #1706

Closed
perriefidelis opened this issue Jan 14, 2019 · 31 comments
Closed

Redesign "welcome message dialog" #1706

perriefidelis opened this issue Jan 14, 2019 · 31 comments

Comments

@perriefidelis
Copy link
Member

The current welcome dialog doesn't look to good with the colours and all. So made a redesign in a mockup of a much better look.

current look
screenshot 2019-01-07 at 12 42 28 pm

redesign
music blocks 3

In my honest opinion we don't have to indicate the move with an icon, once the user uses the mouse on the blue div he/she should be able to change the location of the helpDiv

here is how it looks
music blocks 4

@quozl
Copy link

quozl commented Jan 14, 2019

Looks better to me. Please also make the change to Turtle Blocks JS, on which Music Blocks is based. Here's what it looks like at https://rawgit.com/sugarlabs/turtleblocksjs/master/index.html

tb

@perriefidelis
Copy link
Member Author

I’ve been able to make changes(mock up) on TB using your screenshot. But the welcome dialog doesn’t show when I open Tb on my browser. I tried using 3 browsers (chrome, Firefox and Safari).

@quozl
Copy link

quozl commented Jan 15, 2019 via email

@perriefidelis
Copy link
Member Author

Okay, seen. I'll create an issue right away on tb. but I think the tour should appear the way it does on mb, without having to click on the "?" first

@pikurasa
Copy link
Collaborator

What I see in these pictures looks very nice. Great work!

I do not see a PR for this, nor do I see it in your repo on GH (https://github.com/perriefidelis/musicblocks). Please send a PR with this change.

An aside, it seems from the pictures like the turtle in Turtle Blocks has unintentionally become a mouse. Maybe this needs fixed?

@pikurasa
Copy link
Collaborator

@perriefidelis Any PR for this?

@perriefidelis
Copy link
Member Author

Not yet. I’m not really good at writing codes, I’m trying to look for ways to implement it though but if anyone wants to work on it, they should

@pikurasa
Copy link
Collaborator

How did you make the mockup without changing the code?

@perriefidelis
Copy link
Member Author

I used a design tool for the mockup

@quozl
Copy link

quozl commented Jan 18, 2019

Which design tool?

@jshreyans
Copy link
Contributor

@pikurasa @quozl Hi!
Would it be okay if I worked on the welcome tab as suggested by @perriefidelis
The mockup design looks really nice and I think it would be a great enhancement

@jshreyans
Copy link
Contributor

jshreyans commented Jan 19, 2019

Btw kudos @perriefidelis that's a really subtle and simplistic design yet it suits the website nicely 👍

@perriefidelis
Copy link
Member Author

@quozl I used “FIGMA” (a design tool that helps you to prototype before writing actual codes)

@perriefidelis
Copy link
Member Author

perriefidelis commented Jan 19, 2019

@jshreyans551, that would be great! You can pick from where I stoped: https://github.com/perriefidelis/musicblocks
branch: fix-helpdiv-container

Thanks.

@jshreyans
Copy link
Contributor

Great! Thanks a lot

@jshreyans
Copy link
Contributor

jshreyans commented Jan 20, 2019

@perriefidelis I've worked on the welcome tab but I'm facing certain problems:

  1. Navigation buttons: I tried to position them as you suggested but as soon as they move out of the helpDiv border, that part is automatically cut out. it seems the canvas element in the background is creating the problem

  2. Layout: the layout you suggested involves making an entire new div strip but that means I have to modify the help.js quite a bit since the entire logic is based on the fact that the code renders the buttons div as a table. I'm not sure whether the maintainers would be comfortable with this

I tried to make it look better with some temporary mods:
capture
I tried of thinking for alternative placements for the navigation buttons and I think placing the, on the top strip but both at the left and right extremes would be suitable. Inputs?

@pikurasa
Copy link
Collaborator

I tried of thinking for alternative placements for the navigation buttons and I think placing the, on the top strip but both at the left and right extremes would be suitable. Inputs?

I like the idea of putting it on the left or right side.

/me wonders if "up/down" arrow makes more sense than "left/right"...?

@jshreyans
Copy link
Contributor

jshreyans commented Jan 20, 2019

/me wonders if "up/down" arrow makes more sense than "left/right"...?

I don't think that would matter too much at this stage since there are no animations (like sliding right/left or up/down) when the page content changes. If for instance, there would have been a horizontal slide animation for the content, then the arrow direction would have mattered.

I like the idea of putting it on the left or right side.

Should I implement it?

@walterbender
Copy link
Member

I think the charm and simplicity of Perrie's design is what we are striving for. If the buttons on the side cannot extend outside of the div, then expand the div to make room for them???

@perriefidelis
Copy link
Member Author

the drop shadow is as well too dark, I'm thinking maybe this could help?

https://www.figma.com/file/0ntRQHqYNilzMzSBpOBaUK0J/Musicblocks?node-id=0%3A1

gives you the properties of every element.

steps:

  1. CLICK on the element you want to check it's property
  2. On the right part of the where you have "design, prototype and code", CLICK on Code
  3. SELECT css

@jshreyans
Copy link
Contributor

@perriefidelis Corrected shadow in latest commit

1

@jshreyans
Copy link
Contributor

@walterbender Sure I will try to reach as close as possible to the design. Thanks!

@jshreyans
Copy link
Contributor

@perriefidelis Are the rounded corners looking fine? I thought it would be good addition but I'm not sure. Since it your design after all.

@jshreyans
Copy link
Contributor

Hi! Done with the final view of the welcome tab.
Although there is a slight problem. The drag button image file fails to load. Preview:

2
It seems to be a trivial issue but I can't find a solution. Maybe its because I used relative paths for the address.
Please provide inputs!

@perriefidelis
Copy link
Member Author

Hi @jshreyans551 sorry for the late reply.

design observations:

  • I think you should reduce the corner radius of the rectangle a bit.
  • The colour of the texts should be #505050 not #000000
  • The font you used for the "take a tour" and "skip" isn't Roboto
  • font sizes should increase a bit

@walterbender
Copy link
Member

We should be consistent with the fonts used everywhere else.

@jshreyans
Copy link
Contributor

@perriefidelis Not a problem, thanks for the feedback.
I've made all the listed changes. Although the 'skip' button is no longer there as suggested by @walterbender. This is the latest version:

capture

@pikurasa
Copy link
Collaborator

As far as I can tell, we have merged all the pertinent changes for this issue -- is there something remaining? If so, can someone please enumerate them for clarity?

@jshreyans
Copy link
Contributor

All features have been merged by @walterbender. You can refer to the pull request thread here.
I don't think any changes are remaining

@walterbender
Copy link
Member

I think there is still the issue of white icons on white background not being visible.

@walterbender
Copy link
Member

Should be all set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants