Text tool fixes #19
Merged
Text tool fixes #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- exception was always happening, - Gtk.TextView does not have set_text, - use set_text of the buffer always.
- returning False or True has significance, - use an explicit False instead of allowing it to default to False.
- on Ubuntu 16.04, selecting the text tool then clicking the drawing area seems to do nothing, - caused by the Gtk.TextView stacked underneath the drawing area, - fix is to put the Gtk.TextView last inside the Gtk.Fixed, - did not affect Fedora 18.
- fix bad syntax, - regression introduced in 7e74623.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Note that a floating text insertion will be abandoned if a brush or pencil tool is used while the cursor is flashing. Workaround is to complete the floating text insertion with a click away from the text.