New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port to Python3 #16
base: master
Are you sure you want to change the base?
Port to Python3 #16
Conversation
|
Reviewed. Not tested. Looks good to me |
@quozl I think we do not even need path.py as what we use in other activities is Path class from pathlib. The path.py file is of very old version of python (maybe 2.2). |
|
You're probably right. It was new once. Perhaps a new feature of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-reviewed. Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since bea3301 is not related to Python 2 to 3, let's cherry-pick this in a separate branch and raise a new PR for this commit
…mbViewer doesn't implement draw
6c3e5d4
to
88da156
Compare
Yeah done with changes! |
path.py is based on old Python version(2.2). os.path is what we use most in python3.
|
Thanks. I've reviewed your changes to 83f8ad1. I'm not familiar with the activity; what testing have you done? |
@quozl I am testing with https://wiki.sugarlabs.org/go/Activities/ShowNTell. I didn't find any other thing. |
|
@quozl Have you done testing as I mentioned here??
|
|
No, I've not had time to do testing yet. Can you tell me what testing you did? |
@quozl @pro-panda Please review. Fixes #13