Theme72 #10
Merged
Theme72 #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 12, 2013 13:50
- We had 'indicator-size' harcoded to 26px. Now is a proper number for sugar-72 theme. - Provide new SVG files for the checkbox states, for sugar-72 . Those were optimized with SVGO https://github.com/svg/svgo - Reorder the assets in directories 'assets/100' and 'assets/72'. The Makefile takes care of copying the correct SVG files to the build directory. Fixes #4092 .
- Variable scale_trough_margin was harcoded for both themes. Now is a proper number for sugar-72 theme. - Provide new SVG files for the slider assets, for sugar-72 .
- Provide new SVG files for the radiobutton states, for sugar-72 .
|
Ideally we would just add 'viewBox' attribute in these SVGs in order to make them fit the available space: http://www.w3.org/Graphics/SVG/IG/resources/svgprimer.html#SVG_web But the gtk theme engine does not consider that attribute. I submitted a bug: So the current option is what these patches do, provide different SVGs for the 72% theme. |
|
Looks good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
No description provided.