Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix treeview background, fixes #4855 #62

Closed

Conversation

samdroid-apps
Copy link
Contributor

This also therefore fixes #4857

Main ticket: http://bugs.sugarlabs.org/ticket/4855
Journal ticket: http://bugs.sugarlabs.org/ticket/4857

@walterbender could you test if this breaks anything on fedora 19?

This also therefore fixes #4857
@samdroid-apps samdroid-apps added this to the 0.106 milestone Jun 11, 2015
@samdroid-apps
Copy link
Contributor Author

@walterbender just tested and it didn't seem to break

@godiard
Copy link
Contributor

godiard commented Jun 11, 2015

@samdroid-apps. should we keep the old rule for backward compatibility? Was tested on F18?

@samdroid-apps
Copy link
Contributor Author

The old rule seems to break the newer versions.

It was not tested on F18... But do we still support that?

@quozl
Copy link
Contributor

quozl commented Jun 11, 2015

Let me know when you drop support for Fedora 18 and I'll fork all the repositories. ;-)

@tchx84
Copy link
Member

tchx84 commented Jun 11, 2015

@samdroid-apps yeah, we still support it... a lot of users still run Sugar on top of fc18.

@samdroid-apps
Copy link
Contributor Author

OK.

Would somebody be able to test on f18; I do not have access to an
installation?

On Thu, 11 Jun 2015 4:51 pm Martin Abente Lahaye notifications@github.com
wrote:

@samdroid-apps https://github.com/samdroid-apps yeah, we still support
it... a lot of users still run Sugar on top of fc18.


Reply to this email directly or view it on GitHub
#62 (comment)
.

@quozl
Copy link
Contributor

quozl commented Jun 12, 2015

Sure, please check my test method:

  • apply the patch by hand to /usr/share/themes/sugar-{72,100}/gtk-3.0/gtk-widgets.css
  • restart desktop,
  • verify background in Log Files widget.

This is what it looks like on Fedora 18:

screenshot of log activity

So you will probably have to write a conditional wrapper in the .css.em files, so use GTK_VERSION, discovered by configure.ac, substituted in gtk3/theme/Makefile.am. Let me know if you have any questions on that. GNU autotools for the win.

@samdroid-apps
Copy link
Contributor Author

Replacing...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants