Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly set background color for sub toolbars, fixes #4884 #70

Merged
merged 1 commit into from Oct 10, 2015

Conversation

samdroid-apps
Copy link
Contributor

The .toolbar selector only applies to the toolbar content zone,
so by including the container the margin can also be styled with
the correct background color (specifically for gtk 3.17+).

Requires: sugarlabs/sugar-toolkit-gtk3#255
Fixes: https://bugs.sugarlabs.org/ticket/4884

The .toolbar selector only applies to the toolbar content zone,
so by including the container the margin can also be styled with
the correct background color (specifically for gtk 3.17+).
@samdroid-apps samdroid-apps added this to the 0.108 milestone Sep 9, 2015
@i5o
Copy link
Contributor

i5o commented Oct 10, 2015

Testing

@i5o
Copy link
Contributor

i5o commented Oct 10, 2015

Works for me.

[ignacio@ignacio-pc ~] $ lsb_release -a
LSB Version:    :core-4.1-ia32:core-4.1-noarch:cxx-4.1-ia32:cxx-4.1-noarch:desktop-4.1-ia32:desktop-4.1-noarch:languages-4.1-ia32:languages-4.1-noarch:printing-4.1-ia32:printing-4.1-noarch
Distributor ID: Fedora
Description:    Fedora release 23 (Twenty Three)
Release:    23
Codename:   TwentyThree
[ignacio@ignacio-pc ~] $ pkg-config --modversion gtk+-3.0
3.18.1
[ignacio@ignacio-pc ~] $ 

Tested Pippy and Chat

Patch not applied:
chat without patch
pippy without patch

Applied patch:
chat with patch
pippy with patch

i5o added a commit that referenced this pull request Oct 10, 2015
Properly set background color for sub toolbars, fixes #4884
@i5o i5o merged commit 454b421 into sugarlabs:master Oct 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants