Explicitly style ToolButton insensitive state, fixes #4901 #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The insensitive state of ToolButtons was implicitly styled, however newer Gtk+ versions have broken this behaviour.
|
Testing |
|
XO: http://i.imgur.com/C0yAScV.png In XO is less grey, so maybe we should turn a bit less the opacity. |
|
I will test this patch on XO, to see if it doesn't break the normal behaviour |
|
Doesn't break the normal behaviour on XO. The insensitive color (on read activity) of buttons should be: This could work for now, but for some reason the opacity needs to be a bit more lower/higger? |
|
Tested opacity: 0.5 and the normal color (before the insensitive style were broke) and works. |
|
Tested that opacity on XO, and doesnt broke the normal behaviour ;D |
|
So, In resume, for a nice work we need to change the opacity to 0.5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
The insensitive state of ToolButtons was implicitly styled, however
newer Gtk+ versions have broken this behaviour.
Ticket https://bugs.sugarlabs.org/ticket/4901