Change wide-separators and color properties for new Gtk versions #79
Conversation
| @@ -3,7 +3,7 @@ import os | |||
| import math | |||
|
|
|||
| gtk_major, gtk_minor, gtk_patch = map(int, gtk.split('.')) | |||
| treeview_pseudo_element = gtk_major >= 3 and gtk_minor >= 16 | |||
| new_gtk = gtk_major >= 3 and gtk_minor >= 16 | |||
There was a problem hiding this comment.
One day, new_gtk will be very old. Please use a different variable for different flags
With new gtk version the Separator height has regressed This patch check the new gtk version and if case its >= 3.16 the properties color, and -GtkWidget-wide-separators changes to new values. If version < 3.16 the values aren't changed, this is due to #4175 This is a regression. Fixes #4902
|
Hum, disabling the wide separators isn't helping: That is wayyy thinner than in the designs. Plus, I should probs say that IMO, this bug should be WONTFIX. Having the separators go full height is far more like the palette separators. Keeping things the same is good :) |
|
Yes, you're right. Maybe we can keep it as 'WONTFIX' until we found a right solution. Ignacio Rodríguez 2015-10-11 0:32 GMT-03:00 Sam notifications@github.com:
|
With new gtk version the Separator height has regressed
This patch check the new gtk version and if case its
This is a regression.
Fixes #4902