More gtk3.20 fixes #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tchx84, this pull request may have some urgency for Fedora 24 SoaS quality, and as you know they don't go back and fix problems in Fedora, they rely on upstreams to do it for them. ;-) |
|
I think that there are a few more Gtk+ 3.20 fixes that are needed now, but I'd like to get these merged first. Is there anybody else that is interested in reviewing this? Would any Fedora people that find this interesting? Is anybody who is not a committer yet interested in maintaining Gtk+ 3.20 stuff with me? Or should I just commit Gtk+ 3.20 changes direct to master? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Gtk 3.20.1 was released recently. Unfortunately, there have been some breakages as the css node api moved from 3.19.X to 3.20. (Or maybe the issues were omissions in the original port).
Could this get merged into the sucrose-108 branch so that we can make another tarball for fedora 24? Otherwise SoaS24 will have no sliders :)
Issues (Before)
Sliders:
No selected tab highlight, no entry progress bar:
No combobox arrow:
No toggle button toggled indication:
No arrow, no linked rendering:
Yuck: