Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buddy.props.key is a quoted bytes #433

Open
quozl opened this issue Dec 11, 2019 · 0 comments
Open

Buddy.props.key is a quoted bytes #433

quozl opened this issue Dec 11, 2019 · 0 comments

Comments

@quozl
Copy link
Contributor

quozl commented Dec 11, 2019

On sugarlabs/maze-activity#31 we discovered that Buddy.props.key is an instance of str containing quoted bytes; e.g. "b'value'"

It can be changed back to bytes using eval, but that incurs risk of execution of data.

We need to find out why D-Bus is returning this value in this way.

quozl added a commit to sugarlabs/maze-activity that referenced this issue Dec 11, 2019
* resynchronise TextChannelWrapper with CollabWrapper,

* use Buddy.props.key instead of Buddy.get_key as the former is guaranteed to be available, using get_key did not force the asynchronous D-Bus GetProperties to complete,

* hack for sugarlabs/sugar-toolkit-gtk3#433, buddy.props.key is currently a repr() quoted bytes, so convert the received data into the same format before using it.

* fix argument to _joined_cb when already joined,

Co-authored-by: James Cameron <quozl@laptop.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant