Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No icon is present for description tab in activities's toolbar #465

Closed
S-kus opened this issue Feb 23, 2022 · 5 comments
Closed

No icon is present for description tab in activities's toolbar #465

S-kus opened this issue Feb 23, 2022 · 5 comments

Comments

@S-kus
Copy link

S-kus commented Feb 23, 2022

After opening any activity or even terminal, no icon is rendering for the description tab, not on hovering or clicking as well. As shown below:

sec

third

@quozl
Copy link
Contributor

quozl commented Feb 24, 2022

Thanks for testing. As this is rendered by the toolkit, I'll move the issue there.

@quozl quozl transferred this issue from sugarlabs/sugar Feb 24, 2022
@S-kus
Copy link
Author

S-kus commented Feb 26, 2022

@quozl @chimosky Could you please confirm which icon should be rendered there as in Sugarizer activities the Activity Icon is used for this place.

@quozl
Copy link
Contributor

quozl commented Feb 26, 2022

Huh? It's not an oversight, it's a bug. The icon is edit-description and is set here;

https://github.com/sugarlabs/sugar-toolkit-gtk3/blob/master/src/sugar3/activity/widgets.py#L250

Icon source is here;

https://github.com/sugarlabs/sugar-artwork/blob/master/icons/scalable/actions/edit-description.svg

Do you have conflicting evidence? Thanks.

@S-kus
Copy link
Author

S-kus commented Feb 26, 2022

It's not an oversight, it's a bug

Thanks, @quozl, I am working on it to solve the problem.

Do you have conflicting evidence? Thanks.

No, sorry I misunderstood.

@quozl
Copy link
Contributor

quozl commented Apr 7, 2024

Fixed by sugarlabs/sugar-artwork@7efad05

@quozl quozl closed this as completed Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants