Honor ignore on git #212
Closed
Honor ignore on git #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After add the directory to the IGNORE_DIRS array, we need make the standard procedure to get the list off files for the bundle, get_files_in_git honor the configured ignored files and dirs. That was not a problem until now, because that files was already not added to git, but in the case of the screenshots, are included in git, but we don't want include them in our bundles.
This change remove duplicated code
|
This sounds like the right solution |
|
@samdroid-apps, something like #218 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
No description provided.