New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add get_bundle method to activity.py #236
Conversation
When a programmer need open one activity from other [1] usually need display in the user interface information about the activity to open, like the name or the icon. This method allow get this information, previously only available on jarabe. [1] http://wiki.sugarlabs.org/go/Features/Start_activity_from_another_activity
|
Why are we adding the dbus overhead? The Could we just make this a wrapper without dbus? On Fri, 3 Jul 2015 5:17 am Gonzalo Odiard notifications@github.com wrote:
|
|
@samdroid-apps, we need ask to sugar for the bundle installed. |
|
Huh? On Fri, 3 Jul 2015 7:21 am Gonzalo Odiard notifications@github.com wrote:
|
|
@samdroid-apps, all the logic used to read the bundles is in the toolkit, but Sugar (and the code is in jarabe) have a registry of the activities installed in sugar. If we don't use dbus, need move all that logic to the toolkit, and the worst part is every activity process need store the registry information. |
|
But it works perfectly fine from outside of the jarabe process right now? Is there any reason to increase the surface area of the change so late in On Fri, 3 Jul 2015 7:29 am Gonzalo Odiard notifications@github.com wrote:
|
|
Yes, good reasons. Don't want dependency between an activity and sugar. Hurts everybody in future as sugar changes. The point of isolation must be the toolkit. And performance too, I think. |
|
@samdroid-apps, I explained the reason in my email to sugar-devel. Use jarabe in the activities is forbidden, because is a internal API and we don't warranty stability. |
|
+1 |
When a programmer need open one activity from other [1]
usually need display in the user interface information about the activity
to open, like the name or the icon.
This method allow get this information, previously only available on jarabe.
[1] http://wiki.sugarlabs.org/go/Features/Start_activity_from_another_activity