Deprecate create_jobject parameter on activity.py - Fixes #3450 #240
Conversation
As the ticket describe, create a object in the Journal is no longer optional. The change do not break activities, because the optional parameter is not removed, just ignored.
|
@godiard, I agree this is a easier way out of the problem mentioned in #3450, but is there any particular reason not to go for the solution of covering the unchecked uses of self._jobject? |
|
@tchx84, I think is the safe way to avoid this problem. After the ticket was filled we added even more logic using the jobject (Description button). Not save a object in the journal was a option needed when Sugar started a new instance by default, and we not use create_jobject=False in any maintained activity (or will crash) but this is to avoid errors in old activities. |
|
You can see part of the uses of jobject on widgets.py https://github.com/sugarlabs/sugar-toolkit-gtk3/blob/master/src/sugar3/activity/widgets.py |
|
This now conflicts with the updated documentation. This looks like a good patch though, and nobody seems interested in fixing it. @godiard can you submit a new version of the patch? |
|
@samdroid-apps, sent a new pr #257 |
As the ticket describe, create a object in the Journal
is no longer optional. The change do not break activities,
because the optional parameter is not removed, just ignored.