Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only activate menu items if the mouse releases in them - fixes #4863 #241

Merged
merged 1 commit into from Jul 24, 2015

Conversation

samdroid-apps
Copy link
Contributor

Ticket URL http://bugs.sugarlabs.org/ticket/4863

@quozl wrote a very good ticket which serves as a good description:

The industry convention for mouse driven menu options is for them to be activated when two conditions are met:

  • a button down event occurs with the pointer inside the option, and;
  • a button up event occurs with the pointer inside the option.

The latter condition is not being checked in the Sugar menus.

Reproducer: right-click on the buddy menu, put the pointer over the My Settings option, press down on the button, move the pointer out of the menu, release the button.

Expected result: menu is dismissed.

Observed result: menu is dismissed, and the My Settings option is activated.

@samdroid-apps samdroid-apps added this to the 0.108 milestone Jul 24, 2015
@godiard godiard merged commit 9fc5b49 into sugarlabs:master Jul 24, 2015
@godiard
Copy link
Contributor

godiard commented Jul 24, 2015

Excellent. Next time, please include the explanation in the patch header, that is what will be visible on the git log. (You put the link to the ticket that is ok, but then you need look for the information in the ticket.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants