Add the possibility of display a pixbuf in the palette. #25
Conversation
This is needed to implement preview of images ([1] and [2]) in clipboard buttons. [1] http://wiki.sugarlabs.org/go/Design_Team/Specifications/Clipboard#Previews [2] http://wiki.sugarlabs.org/go/File:Frame-05.jpeg Signed-off-by: Gonzalo Odiard <gonzalo@laptop.org>
|
This pull request is needed by sugarlabs/sugar#67 |
|
A bit confused here. You seem to be putting the image in the primary box, the screenshot you linked seems to put it in the secondary box, "below" the menu. Am I missing something? |
|
No. The image is a guide, see the order between the primary and the secondary box is wrong too. |
|
Can you post a screenshot of it as implemented please? |
|
Implementation screenshot: |
|
Feels wrong to me to put it in the header. Though it's really up to design. @manuq what do you think? |
|
The text preview is in the header too. |
|
I think the text / title of the clipboard image should be in the palette header. The header will be above or below the content depending on the available space (if the palette unfolds down or up) and also should be separated with a line. So this looks good: http://wiki.sugarlabs.org/go/File:Frame-05.jpeg And this looks wrong: http://dev.laptop.org/~gonzalo/images/clipboard_image_preview.png Gonzalo says that he added the text to the palette header. Maybe this is a bug in the palette itself? |
|
Per irc discussion punted to 0.102. |
This is needed to implement preview of images ([1] and [2]) in clipboard buttons.
[1] http://wiki.sugarlabs.org/go/Design_Team/Specifications/Clipboard#Previews
[2] http://wiki.sugarlabs.org/go/File:Frame-05.jpeg
Signed-off-by: Gonzalo Odiard gonzalo@laptop.org