Fix translations in non standard prefix #37
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This drops a lot of code at the same time. The code in __init__ was: * Using a SUGAR_PREFIX environment variable that is not defined anywhere * Hardcoding prefix to /usr * Setting up the sugar-base domain which doesn't exist anymore The i18n module code was overcomplex because it was thought for language packs which we don't support anymore, it was not handling correctly locales with a country prefix, it was hard coding the python prefix and it was not sorting the directories as it intended too anyway. The logic is very simple now. Use the locale directory in the same prefix sugar-toolkit-gtk3 was installed, unless SUGAR_LOCALEDIR is defined (for self contained bundles).
|
|
||
|
|
||
| if 'SUGAR_PREFIX' in os.environ: | ||
| prefix = os.environ['SUGAR_PREFIX'] |
There was a problem hiding this comment.
Absolutely. I just checked that SUGAR_PREFIX is not set in olpc builds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This drops a lot of code at the same time. The code in
init was:
defined anywhere
The i18n module code was overcomplex because it was thought
for language packs which we don't support anymore, it was
not handling correctly locales with a country prefix, it
was hard coding the python prefix and it was not sorting
the directories as it intended too anyway.
The logic is very simple now. Use the locale directory in
the same prefix sugar-toolkit-gtk3 was installed, unless
SUGAR_LOCALEDIR is defined (for self contained bundles).