Make webactivity compatible with webkit1 #54
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a env variable SUGAR_USE_WEBKIT1 exists, uses a local webserver, borrowed from wikipedia activity. Other compatibility changes are needed, like variables and methods names. When use webkit1 the web inspector is not enabled, because do not work. Signed-off-by: Manuel Quiñones <manuq@laptop.org> Signed-off-by: Gonzalo Odiard <gonzalo@laptop.org>
|
A thread on the ml was opened about this, let's see if we can build a consensus there before getting into the implementwtion |
|
From the discussion on the mailing list, this is going to be a short time hack and we are not going to require webkit2 patches to not break webkit2. Thus I think it would be better to keep the two implementations completely separated, even if it means to duplicate code, i.e. put all of this in a webkit1.py module and sugar-activity-web to import webactivity.WebActivity or webkit1.WebActivity depending on the env variable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
If a env variable SUGAR_USE_WEBKIT1 exists,
uses a local webserver, borrowed from wikipedia activity.
Other compatibility changes are needed, like variables and methods
names.
When use webkit1 the web inspector is not enabled, because do not work.
Signed-off-by: Manuel Quiñones manuq@laptop.org
Signed-off-by: Gonzalo Odiard gonzalo@laptop.org