Fix textarea expanding, fixes #4832 #118
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes the palette expand on the x-axis when the textarea in the activity palette is expanded. This means it does not overflow. This commit also puts limits on the size of the text area, so the user can not drag it to be small and weird looking.
|
@samdroid-apps you too fixed it |
|
@samdroid-apps , maybe is better avoid resize at all, using "resize: none;". http://stackoverflow.com/questions/5235142/how-to-disable-resizable-property-of-textarea |
|
To be more clear, I think resize: none would be applied to all the textareas. |
samdroid-apps
added a commit
to samdroid-apps/sugar-web
that referenced
this pull request
Apr 9, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This commit makes the palette expand on the x-axis when the textarea
in the activity palette is expanded. This means it does not overflow.
This commit also puts limits on the size of the text area, so the user
can not drag it to be small and weird looking.
Bug link: http://bugs.sugarlabs.org/ticket/4832