Change mime_type in DetailView #148
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a ComboBox in the DetailView to change the mime_type, for GCI2013
|
The patch looks good now! And it works fine. As @dnarvaez said in the previous pull request, we need to consider this patch and it's design for upstream submission. |
|
@tchx84 Could you start a thread on the ml to discuss this? |
|
I don't see much of a consensus that we should add this from the mailing list discussion. |
ChristoferR
referenced
this pull request
in ChristoferR/sugar-toolkit-gtk3
Nov 30, 2013
|
Closing for now then. If we come to consensus that we want the feature we can reopen. Thanks for your contribution, it's much easier to discuss features if an implementation is available. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Added a ComboBox in the DetailView to change the mime_type, for GCI2013