Avoid executing the query two times at ObjectChooser startup #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The object chooser was setting at initialization properties in the MainToolbox. Every set triggered a query change, setting both parameters simultaneously, the query is executed only one time. This reduce ObjectChooser startup time, specially with big Journals. Signed-off-by: Gonzalo Odiard <gonzalo@laptop.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
The object chooser was setting at initialization properties
in the MainToolbox. Every set triggered a query change,
setting both parameters simultaneously, the query is executed
only one time. This reduce ObjectChooser startup time,
specially with big Journals.
Signed-off-by: Gonzalo Odiard gonzalo@laptop.org