Rework the wireless control panel section to respect non-wireless connec... #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nections. Fixes #4410 https://bugs.sugarlabs.org/ticket/4410 The 'Discard network history' button is peculiar to Sugar, and is destructive to all non-wireless connections, despite being in the 'Wireless' section of the control panel. Relabel this button and code variables to be specific to wireless connections. Recode tests for non-sugar-wireless connections to exclude non-wireless connections. Relabel the 'Radio' checkbox and instructions to avoid confusion over its state and action. Test for the availability of wireless hardware with the kernel's sys filesystem before building and showing the 'Wireless' section on each invocation of the 'Network' panel.
|
Closing to fix some python flake. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
...tions.
Fixes #4410 https://bugs.sugarlabs.org/ticket/4410
The 'Discard network history' button is peculiar to Sugar, and
is destructive to all non-wireless connections, despite being in
the 'Wireless' section of the control panel.
Relabel this button and code variables to be specific to wireless
connections.
Recode tests for non-sugar-wireless connections to exclude
non-wireless connections.
Relabel the 'Radio' checkbox and instructions to avoid confusion
over its state and action.
Test for the availability of wireless hardware with the kernel's
sys filesystem before building and showing the 'Wireless' section
on each invocation of the 'Network' panel.