Fixed ticket 4686 [Version 2]. #259
Conversation
wiki.laptop.org, where the pages used to update the activities are located, usually serve old cached pages. We can avoid that setting the header Cache-Control' = 'max-age=600', and be sure the page is not older than 10 minutes. A reason to set this at client side, and not solve it only in wiki.laptop.org, is the posibility of intermnediate caches, as provider or school server proxies, or the use of other activities servers in particular deployments. Signed-off-by: Gonzalo Odiard <godiard@sugarlabs.org>
Is better than the current font. By the way the html version looks better formated. We should show this in a webview: http://www.gnu.org/licenses/gpl-2.0-standalone.html
The object_id can be retrieved in more than one chunk, then the parser should take carr of that. Signed-off-by: Gonzalo Odiard <godiard@sugarlabs.org>
Without this patch, the updater show a message 'Your software is up-to-date', when can't connect to the server. Signed-off-by: Gonzalo Odiard <godiard@sugarlabs.org>
Updates LGPL-python.txt to read the FSF's new address.
…unning01-patch-2
This is needed to allow the next update request to work. This was missed in the last patch "Show a error message if the activity updater can't connect to the server" Signed-off-by: Gonzalo Odiard <godiard@sugarlabs.org>
If the user changes the username on My Setting -> About me view and then reverts it to the initial username, remove the warning about restart.
|
@manuq : Review please. |
|
Looks great, I will test. |
|
@walterbender : I've made the changes you suggested and ran pep8 on the code. |
Sure. |
|
@walterbender : I think that was all. Anything else? |
|
@walterbender : Done. Also, I've squashed all the previous commits into a single commit so that history doesn't clutter up. Let me know if anything more is needed. |
|
Unrelated, but how do you squash commits and keep them on the same branch?
|
|
@samdroid-apps : |
|
Interesting solution, using python textwrap library. I just hope line wrapping could be done with GTK. I think is much better that way. I'll give a look at the gtk way. Otherwise let's just go with this. |
|
Are you referring to the |
|
Wooow! Great patch! #202 this was my try for GCI :) 2014-03-06 16:06 GMT-02:00 Prasoon Shukla notifications@github.com:
Ignacio Rodríguez |
|
This really needs to be done with gtk. TextView has wrapping support too if that's what you are using. |
|
@dnarvaez : Well, I had tried wrapping text using gtk but IIRC, I just couldn't get the output to be consistent. I will try some other approach with gtk, I suppose. |
|
@prasoon2211 If you need help figuring out what is wrong feel free to post code/screenshots on the mailing list. |
* Used Gtk.Label with Pango based ellipsize for wrapping and ellipsizing. * Fallback for Gtk < 3.10
EDIT: See #313 for the new version of the patch.
See http://bugs.sugarlabs.org/ticket/4686 for more.
Also, please see #244. This patch has the suggested improvements.
Large activity detail
Small activity detail