Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't offer to join beyond maximum participants #355

Closed

Conversation

@walterbender
Copy link
Member

walterbender commented Apr 30, 2014

This is patch checks to see how many participants are sharing an
activity. If the maximum has been reached, then the Join palette menu
item is not shown.

This patch depends on two patches to sugar-toolkit-gtk3 (#138) that
enable setting max_participants in activity.info and only impacts
activities where that field has been set.

Also, since we added caching of activity bundles in the toolkit, we
take advantage of that caching in view/viewhelp.py,
view/viewsource.py, and journal/misc.py to reduce file I/O.

Replaces #339

This is patch checks to see how many participants are sharing an
activity. If the maximum has been reached, then the Join palette menu
item is not shown.

This patch depends on two patches to sugar-toolkit-gtk3 (#138) that
enable setting max_participants in activity.info and only impacts
activities where that field has been set.

Also, since we added caching of activity bundles in the toolkit, we
take advantage of that caching in view/viewhelp.py,
view/viewsource.py, and journal/misc.py to reduce file I/O.

Replaces #339
@godiard

This comment has been minimized.

Copy link
Member

godiard commented May 2, 2014

I have tested this (and the toolkit pr) and works as expected, even with gtk2 activities.
I have pushed both prs.
Would be good add documentation, by example suggest use the cached bundle instead of ActivityBundle (is not evident by the function name). Also we need document the change in the activity.info file in http://wiki.sugarlabs.org/go/Development_Team/Almanac/Activity_Bundles,
and make a call to activity developers to updated it.

@godiard godiard closed this May 2, 2014
@walterbender

This comment has been minimized.

Copy link
Member Author

walterbender commented May 2, 2014

On Fri, May 2, 2014 at 9:46 AM, Gonzalo Odiard notifications@github.comwrote:

I have tested this (and the toolkit pr) and works as expected, even with
gtk2 activities.
I have pushed both prs.
Would be good add documentation, by example suggest use the cached bundle
instead of ActivityBundle (is not evident by the function name). Also we
need document the change in the activity.info file in
http://wiki.sugarlabs.org/go/Development_Team/Almanac/Activity_Bundles,
and make a call to activity developers to updated it.

Updated. Will also add it to the release notes.


Reply to this email directly or view it on GitHubhttps://github.com//pull/355#issuecomment-42033379
.

Walter Bender
Sugar Labs
http://www.sugarlabs.org

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.