Hide 'Invite to <activity>' menu option if the activity cant be shared #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this changes, the 'Invite to <activity>' option in the buddy menu only show if max_participants is <= 1. max_participants is a field off activity.info, the default is 0 so, if you want you activity sharable set max_participants to one number > 1 Fixes SL#2702
|
Would be good make this change in Sugar 0.106, to make sure all the activities implementing collaboration have the activity.info files updated. Can we tag this pr as approved for 0.106? |
|
Added link to this pr in http://bugs.sugarlabs.org/ticket/2702 and added tag "patch" |
|
|
||
| if not is_unshareable: | ||
| bundle_activity = ActivityBundle(activity.get_bundle_path()) | ||
| self._max_participants = bundle_activity.get_max_participants() |
There was a problem hiding this comment.
Why self.? Is this used later?
samdroid-apps
added a commit
to samdroid-apps/sugar
that referenced
this pull request
Mar 29, 2015
|
I merged this 10 days ago... But I forgot to say: Merged! |
|
@samdroid-apps you merged #446 :P |
|
Need more work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
With this changes, the 'Invite to ' option in the
buddy menu only show if max_participants is <= 1.
max_participants is a field off activity.info, the default is 0
so, if you want you activity sharable set max_participants
to one number > 1
Fixes SL#2702