Brightness in frame try2 #437
Conversation
|
Requires sugarlabs/sugar-artwork#39 |
|
@sugarlabs/owners, could this be reviewed for 0.106? |
|
@samdroid-apps I can review this. Please prepare (or update) the feature page in the wiki. |
|
Hello @samdroid-apps, I have reviewed and tested it using sugar-build with Fedora 22 and Gnome. First thing I noticed is that the DBUS methods you are using only works with unity-settings-daemon. Keep in mind that Ubuntu folks forked gnome-settings-daemon and will be nice to support both. To give you some examples: For unity-settings-daemon (the same one you are using): See more details at: http://bazaar.launchpad.net/~unity-settings-daemon-team/unity-settings-daemon/trunk/view/head:/plugins/power/gsd-power-manager.c#L94 For gnome-settings-daemon: Note there is no SetPercentage, but instead there is a Brightness property. You can see more details on https://git.gnome.org/browse/gnome-settings-daemon/tree/plugins/power/gsd-power-manager.c?h=gnome-3-14#n80 Regarding the model code organization, please:
Great work so far! |
|
Subscribed. Reviewed. Great work so far. Agree with comments above. We need to figure out if there is a way to control brightness without requiring gnome-settings-daemon or unity-settings-daemon, which are not present when Sugar is run as a desktop from lightdm. To that end I've been looking at how these daemons make the brightness change, but no final result yet. The process that writes to sysfs is the X server, but I don't know how the X server is given the command. It may be one of the X protocol messages. http://dev.laptop.org/ticket/12888 is where I'm tracking this. Won't get to this for a week or so, so if anybody else figures it out, let me know. |
|
@quozl, I use the brightness file, which is writable on the xo |
|
@samdroid-apps, yes, I see that, but it won't work on hardware other than the XO. I'm fine with merge for XO, but not okay with merge for other hardware. |
|
@quozl I do have a read only fallback :) |
|
Heh. Indeed you do. But I'm staring at a very bright screen and reaching for my sunglasses. ;-) |
| icon_number = math.ceil(float(brightness.get_brightness()) * 3 | ||
| / brightness.get_max_brightness()) * 33 | ||
| if icon_number == 99: | ||
| icon_number = 100 |
There was a problem hiding this comment.
Note to self: there is a function in sugar3.graphics.icon that does this
|
@tchx84 Thanks for the info and review! I will restructure my code to be MV based. I am using the GNOME control system in my code, not the Unity one. (I haven't had Ubuntu installed for years). I will look into supporting the Unity version though. |
|
@samdroid-apps, you are right! My bad. But are you able to test it? I think there is something missing because all I get is: ie., you can reproduce it by running the shell example I showed you both from your gnome terminal and then from sugar terminal. The later will fail. There is probably something missing at configuration level. |
|
Yes I am having the same issue. It may be that sugar-build does not share a dbus with the outside world. I will look further into it later. |
|
You have to know where this feature is implemented. There is no settings-daemon in the scenario I'm looking at; Sugar as a desktop. I suggest not looking into supporting Unity or Ubuntu, but instead understand how both gnome-settings-daemon and unity-settings-daemon implement what they do (for brightness), and reimplement that in Sugar. It need not be a sugar-settings-daemon. I doubt that sugar-build is a suitable environment for designing or testing brightness control. It is artificial, and is not deployed. |
|
@samdroid-apps , think you could make the changes I suggested earlier to organize the model code? I am looking into what James is suggesting, should have news soon. |
|
|
We will use a new approach as per the mailing list. |
This adds a brightness model and screenshot model (from existing screenshot code). This is then used to create a display frame icon, which houses the brightness and screenshot.
The brightness thing is a bit weird and has limitations. It either manipulates the file directly or if uses GNOME SettingsDaemon over dbus. If none of theses are writable, you get a read only brightness in the frame.