Don't save jabber without user confirmation. #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now the jabber autosave when the user press enter in entry, with this patch, that no happens. The users needs to click accept button in the control panel. Removed the timeout, because we need to set it inmediatly. Removed the change signal in entry, because, now its set when the user click on accept and no enter in entry.. Added "apply", so, if the user click on accept, if apply exists, it call apply_jabber, the function get the text of the entry, and set it to current jabber server. We need that, because If we dont want to show restart alert, we couldnt get the response. Possible Fix SL#618
|
Is there a ticket behind this? Or a GCI task? EDIT: found it http://bugs.sugarlabs.org/ticket/618 |
|
@tchx84 Forget to add it to github description, SL#618 |
|
Merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Right now the jabber server entry autosaves when the user presses enter.
With this patch, that no longer happens. The user must click the accept
button in the control panel in order to save a new jabber server entry.
The timeout has been removed because we need now reset the server immediately
when the accept button is pressed.
The change-signal handler has been removed because we only want to change the
server name when the user clicks on accept button.
An apply flag has been added so if the user clicks on accept, we know
whether or not the server should be updated.